Open
Conversation
AmberPotion
requested changes
Oct 1, 2024
AmberPotion
left a comment
There was a problem hiding this comment.
Please fix merge conflicts in order for the PR to be approved.
Author
|
fixed conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Implement Mediator Pattern and Rename Classes
Overview:
This pull request introduces the Mediator design pattern to improve communication between objects in our game architecture. Additionally, several classes have been renamed to enhance code clarity and align with the new design structure.
Changes Made:
Mediator Pattern Implementation:
GameMediatorclass that centralizes communication between different components, such as players, obstacles, and rain.GameMediator, reducing direct dependencies between classes.Player,Obstacle, andRAINclasses to interact through theGameMediator.Class Name Changes:
SubjecttoBEE_PLAYERto better reflect its role in the game.ObservertoRAINto clarify its purpose and enhance readability.Benefits:
Type of change
Code
How Has This Been Tested?
Compiled and ran with
skm g++ program.cpp player.cpp obstacle.cpp GameManager.cpp -o game.exe
Checklist
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have requested a review from team members on the Pull Request